[pull] release from appsmithorg:release#253
Merged
Merged
Conversation
## Description The `build-docker-image` workflow currently distributes the system-under-test image to test jobs by saving it to a gzipped tarball (single-threaded, ~4 minutes) and storing it in the Actions cache, which every test shard then restores as a single blob (~3 minutes each, worse under fan-out contention since the restores can't parallelize). This switches distribution to GHCR: the build job pushes the image to `ghcr.io/<repo>-citest:run-<run_id>`, and test jobs pull it from there. Registry pulls are layer-parallel and CDN-backed. Measured on the EE repo across a 20-shard run: median image acquisition dropped from ~218s to 74s per shard, and the build job no longer spends ~4 minutes on `docker save | gzip`. Changes: - `build-docker-image.yml`: push the built `cicontainer` image to GHCR using `GITHUB_TOKEN`; remove the tar/gzip/cache-save steps. - `ci-test-custom-script.yml`, `ci-test-playwright.yml`: pull the image from GHCR and tag it back to `cicontainer`, so downstream `docker run` references are unchanged. - `ci-test-limited.yml`, `ci-test-limited-with-count.yml`: same, honoring `previous-workflow-run-id` for the image-reuse path (`run-<previous-id>` tag). Registry tags outlive Actions cache eviction, so reuse becomes more reliable, bounded by the retention window below. - `ghcr-citest-retention.yml` (new): daily prune of `run-*` package versions older than 7 days (each is ~2 GB). Supports manual dispatch with a dry-run flag. Notes: - The GHCR package is created on first push and defaults to private, linked to this repository. Pulls inside Actions use `GITHUB_TOKEN`; no new secrets or permissions are required. - Fork-PR paths are unaffected: fork-triggered `pull_request` events never reach the build job (existing gate), and the `/ok-to-test` flow runs via `repository_dispatch` in base-repo context. - A `/ci-test-limit` rerun referencing a run that predates this change will not find a registry tag for it; this resolves itself as new runs accumulate. Ref: APP-15259 ## Validation - After merge, run `/ci-test-limit` and `/ci-test-limit-count` on a test PR, including one rerun that exercises `previous-workflow-run-id`. - Dispatch `ghcr-citest-retention.yml` with `dry-run: true` to confirm the token can enumerate and would prune package versions before the first scheduled run. 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * CI now pushes and pulls test container images via the GitHub Container Registry instead of caching/loading tarball artifacts. * Test jobs retrieve run-specific image tags so downstream steps pull images by tag. * Added a scheduled/manual cleanup workflow to prune old test image versions in the registry with configurable retention and dry-run options. <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- This is an auto-generated comment: Cypress test results --> > [!WARNING] > Tests have not run on the HEAD a55f67e yet > <hr>Wed, 10 Jun 2026 20:11:30 UTC <!-- end of auto-generated comment: Cypress test results --> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )